Project

General

Profile

Actions
Copy link

Bug #18686

closed

Problems with authors having ' in the name

Added by Andrea Dell'Amico almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Michele Artini
Target version:
ISTI Open Portal Issues
Start date:
Feb 28, 2020
Due date:
% Done:

100%

Estimated time:
Quote

Description

If I search Andrea Dell'Amico, the result is empty. When I remove the ', the publications associated to my name appear.

Files

Edit attached files Download all files
Screenshot 2020-02-28 at 19.09.03.png (49.6 KB) Screenshot 2020-02-28 at 19.09.03.png Leonardo Candela, Feb 28, 2020 07:12 PM Delete
Screenshot 2020-02-28 at 19.21.33.png (144 KB) Screenshot 2020-02-28 at 19.21.33.png CNR Authros with ' in the name Leonardo Candela, Feb 28, 2020 07:22 PM Delete
Add

Subtasks

Add

Related issues

QuoteActions
Copy link
 #1

Updated by Leonardo Candela almost 5 years ago

The problem is with the ' in the query

The following queries both return the 12 records we have

https://openportal.isti.cnr.it/results?qv=andrea+dell+amico

https://openportal.isti.cnr.it/results?qv=andrea+amico

yet they are not the solution. We should find a solution since also the browse by author fails to display the 12 records.

QuoteActions
Copy link
 #2

Updated by Leonardo Candela almost 5 years ago

  • Subject changed from While we wait for the new issue tracker: my surname breaks the search (as often does) to Problema with authors having ' in the name
Actions
Copy link
 #3

Updated by Leonardo Candela almost 5 years ago

  • Subject changed from Problema with authors having ' in the name to Problems with authors having ' in the name
QuoteActions
Copy link
 #4

Updated by Leonardo Candela almost 5 years ago

We do have 14 authors with ' in the name ... see screenshot.

QuoteActions
Copy link
 #5

Updated by Michele Artini almost 5 years ago

  • Status changed from New to Feedback

The bug has been introduced recently to fix a XSS vulnerability.

In particular I changed the read of each input parameter from:

$mainValue  = $jinput->get('qv', '', 'STRING');

to

$mainValue  = htmlspecialchars($jinput->get('qv', '', 'STRING'), ENT_QUOTES);

The problem was mainly related with the parameter of the free search, so I changed only the read of the browse parameter in:

$mainValue  = htmlspecialchars($jinput->get('qv', '', 'STRING'), ENT_COMPAT);
QuoteActions
Copy link
 #6

Updated by Leonardo Candela almost 5 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF