Feature #9114

DataMiner - Add pagination to Workspace Explorer

Added by Giancarlo Panichi over 2 years ago. Updated about 2 years ago.

Status:ClosedStart date:Jun 30, 2017
Priority:HighDue date:
Assignee:Francesco Mangiacrapa% Done:

100%

Category:portlets-widgets
Sprint:zz - DataMiner - Improve the portlet
Milestones:
Duration:

Description

To improve the user experience and the response speed of the DataMiner we must add pagination to the Workspace Explorer Widget. Also, the HL will have to offer pagination access to directories and files

test.png - Test WorkspaceExplorerPaginated (70.2 KB) Giancarlo Panichi, Nov 09, 2017 07:06 PM

test.png - Error Pager (74.6 KB) Giancarlo Panichi, Nov 13, 2017 02:16 PM

test.png - Error Pager 2 (87 KB) Giancarlo Panichi, Nov 13, 2017 06:56 PM

1862
1881
1883

Related issues

Related to BlueBRIDGE - Project Task #9043: Develop shapefile custom uploader R process Closed Jun 27, 2017
Related to gCube - Feature #9140: Add pagination to HL Closed Jul 04, 2017
Related to gCube - Release #10213: portlets-widgets.workspace-explorer.1-7-1 Released Nov 06, 2017
Related to gCube - SW Test #10302: org.gcube.portlets.user.data-miner-manager.1-6-0 Tested on Preprod Nov 10, 2017 Nov 17, 2017

History

#1 Updated by Francesco Mangiacrapa over 2 years ago

Hi Giancarlo,

Pagination facility is an utility needed if workspace items retrieved either they are so many or they have so many properties (gcube-properties displayed as columns)
Implement pagination workspace-side is of little use, because time to get items is consumed by HL-side. For this reason, I think we need to extend HL interface (and behavior) in order to get items also by indexing..

i.e. implementing:

  1. getChildren for folder with start (S) and offset (X) indexes in order to get X items from S index;
  2. getTotalChildren for folder to get number of children of a folder.

After that, I will able to implement pagination workspace-side adding also some optimization i.e. caching of items and so on..

@valentina.marioli@isti.cnr.it please, Can you open a ticket regarding this activity HL-side? Thanks

#2 Updated by Giancarlo Panichi over 2 years ago

  • Priority changed from Normal to High

#3 Updated by Giancarlo Panichi over 2 years ago

#4 Updated by Valentina Marioli over 2 years ago

#5 Updated by Francesco Mangiacrapa over 2 years ago

  • Status changed from New to In Progress

#6 Updated by Francesco Mangiacrapa over 2 years ago

  • % Done changed from 0 to 20

I'm maintaining and extending the code in order to provide a "double" solution.. You will able to instance the "old" Workspace Resource Explorer without pagination and the new one that will use the pagination facility like shown here: http://samples.gwtproject.org/samples/Showcase/Showcase.html#!CwCellTable

#7 Updated by Francesco Mangiacrapa over 2 years ago

  • % Done changed from 20 to 50

#8 Updated by Francesco Mangiacrapa over 2 years ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Feedback

@g.panichi@isti.cnr.it workspace explorer whit pagination facility is available on nexus (version 1.7.0).
You can see how to use it reading the wiki-page: https://wiki.gcube-system.org/gcube/GCube_Widgets_Store#Workspace_Explorer
In particular the pagination is documented at: https://wiki.gcube-system.org/gcube/GCube_Widgets_Store#Workspace_Resource_Explorer_with_pagination_facility

#9 Updated by Francesco Mangiacrapa about 2 years ago

Hi @g.panichi@isti.cnr.it,

I just performed a fix regarding the bug that you had reported. Please, try again the application and let me know if it works now. (The widget version deployed on maven is 1.7.1)

#10 Updated by Francesco Mangiacrapa about 2 years ago

  • Related to Release #10213: portlets-widgets.workspace-explorer.1-7-1 added

#11 Updated by Francesco Mangiacrapa about 2 years ago

  • Status changed from Feedback to Closed

I'm going to close this ticket. Please, you reopen it if needed

#12 Updated by Giancarlo Panichi about 2 years ago

  • Status changed from Closed to In Progress
  • File test.png added

After some tests, these things emerged:

  • The scrollbar does not appear if I resize the window
  • If there are many items, the scrollbar does not appear
  • Grid cells do not support word-wrap style: break-word;

Please, can you fix these problems?
Thanks

#13 Updated by Giancarlo Panichi about 2 years ago

  • % Done changed from 100 to 80

#14 Updated by Maria Di Girolamo about 2 years ago

  • Related to SW Test #10301: org.gcube.portlets.user.statistical-algorithms-importer.1-8-0 added

#15 Updated by Maria Di Girolamo about 2 years ago

  • Related to deleted (SW Test #10301: org.gcube.portlets.user.statistical-algorithms-importer.1-8-0)

#16 Updated by Maria Di Girolamo about 2 years ago

  • Related to SW Test #10302: org.gcube.portlets.user.data-miner-manager.1-6-0 added

#17 Updated by Francesco Mangiacrapa about 2 years ago

  • % Done changed from 80 to 100
  • Status changed from In Progress to Feedback

Hi @g.panichi@isti.cnr.it,

Last Friday I discovered a specif rule (that's "an OVERFLOW: hidden") in the Portal (it could be due to Liferay-CSS or GWT-Bootstrap-CSS or I don't know), that does not allow the vertical scroll displaying.
I'm working on this "external" issue and I replaced all panels that builds the pagination facility in order to move the scrolling directly into widget (in particular on the grid part).

Let me know if this improvement works in the dataminer portlet.

#18 Updated by Giancarlo Panichi about 2 years ago

  • Status changed from Feedback to In Progress
  • File test.png added

Hi Francesco, I can see the scrollbar, but I do not see the Pager.

#19 Updated by Francesco Mangiacrapa about 2 years ago

  • Status changed from In Progress to Feedback

Please, Giancarlo, try again. Thanks

#20 Updated by Giancarlo Panichi about 2 years ago

  • Status changed from Feedback to In Progress
  • File test.png added

Hi Francesco, how you can see from the image, now the Pager seems to be present, but remains out of the visible area.

#21 Updated by Francesco Mangiacrapa about 2 years ago

I just updated code to the dataminer portlet setting the height to internal scroll at 270px and now the pager is shown correctly
https://next.d4science.org/group/nextnext/dataminer
This solution is just a work-around, but please @g.panichi@isti.cnr.it, you perform the merging with dataminer released.
However, I'm going to change such work-around with a definite solution, asap.

#22 Updated by Gianpaolo Coro about 2 years ago

  • % Done changed from 100 to 90

Hi Francesco, the list of computations is now ordered by some random rationale, whereas in the current production version and in the training courses the used ordering is by date, otherwise it is very confusing to use the interface.

Since ordering is more important than pagination, I think this version of the widget should not be released until ordering by date will be supported.

#23 Updated by Giancarlo Panichi about 2 years ago

Hi @francesco.mangiacrapa@isti.cnr.it , I checked the HL, I saw that only methods supporting pagination without SortMetadata and FilterMetadata were implemented in HL for WorkspaceFolder. See:

public List<WorkspaceItem> getAllChildren(boolean showHidden, int limit, int offset) throws InternalErrorException;

public List<WorkspaceItem> getChildren(int limit, int offset, boolean showHidden) throws InternalErrorException;

This request can only be supported or with a widget solution that simulates the sort with pagination, or by extending the HL with these features.
For this reason, in release 4.8.0 we will retain the old widget(that support sort) and move the new widget to the next release.

#24 Updated by Francesco Mangiacrapa about 2 years ago

Hi Gianpaolo and Giancarlo,

thanks for your feedback.
Yes, at the moment, It is not possible to perform sorting by folder children (on all items) since HL does not implement Sort facility to pagination request.
An enhancement is needed to HL. Please, @g.panichi@isti.cnr.it can you open a ticket to @lucio.lelii@isti.cnr.it? Thanks.
I will add a 'sort by' facility to WE asa above ticket will be completed.
Moreover, you consider to close current ticket and open a new one for the next release.

#25 Updated by Francesco Mangiacrapa about 2 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

I'm going to close this ticket, my comments on this activity are reported at https://support.d4science.org/issues/9114#note-24

Also available in: Atom PDF