Task #8368

Release #8211: gCube Release 4.5.0

Release #8420: data-access-4.5.0

org.gcube.data-access.comet-mapping-format to be removed

Added by Maria Di Girolamo over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:May 02, 2017
Priority:ImmediateDue date:
Assignee:Lucio Lelii% Done:

100%

Category:vre-management
Sprint:gCube Release 4.5.0
Milestones:
Duration:

Description

comet-mapping format should be removed from this release (it's a deprecated file).
But org.gcube.data-analysis.operation-comet depends on it: http://eticsbuild2.research-infrastructures.eu/BuildReport/home/AllBuilds/org.gcube.4-5-0/BUILD_2/comet-mapping-format.0.0.1.
Please @fabio.sinibaldi@isti.cnr.it and/or @lucio.lelii@isti.cnr.it , is it possible to refactor operation-comet in order to remove comet-mapping-format?


Related issues

Related to gCube - Release #8923: org.gcube.data-access.comet-mapping-format (to be removed) Removed Jun 13, 2017

History

#1 Updated by Maria Di Girolamo over 2 years ago

  • Copied from Task #7858: Refactor of the org.gcube.vre-management.ghnmanager-client.1-1-0-2 added

#2 Updated by Maria Di Girolamo over 2 years ago

  • Copied from deleted (Task #7858: Refactor of the org.gcube.vre-management.ghnmanager-client.1-1-0-2)

#3 Updated by Maria Di Girolamo over 2 years ago

  • Subject changed from org.gcube.data-access.comet-mapping-format to org.gcube.data-access.comet-mapping-format to be removed

#4 Updated by Maria Di Girolamo over 2 years ago

  • Parent task changed from #8211 to #8420

#5 Updated by Fabio Sinibaldi over 2 years ago

The whole module operation-comet is meant to interact with comet logic. If we're dismissing the latter, I think we're safe to dismiss operation-comet as well. @lucio.lelii@isti.cnr.it, can we do it on this release?

#6 Updated by Pasquale Pagano over 2 years ago

@gianpaolo.coro@isti.cnr.it, is/was comet used in Bionym to generate the reference dataset?

#7 Updated by Gianpaolo Coro over 2 years ago

operation-comet is not used by BiOnym directly. I guess it can be removed.

#8 Updated by Maria Di Girolamo over 2 years ago

org.gcube.data-analysis.tabular-data-service depends on operation-comet.
Please , @lucio.lelii@isti.cnr.it is it possible refactor tabular-data-service removing operation-comet?

#9 Updated by Lucio Lelii over 2 years ago

from the TabularData service point of view comet can be removed without any change in the service.
The problem could be in the interface side, I don't remember if @g.panichi@isti.cnr.it integrated this operation in his components.

#10 Updated by Giancarlo Panichi over 2 years ago

This operation is not present among those declared in the current TabMan interface.
I do not know if it is an internal operation in the service.

#11 Updated by Maria Di Girolamo over 2 years ago

At the moment, I can set operation-comet and comet-mapping-format as dismissed in ETICS configuration.

In the next release we can think to remove them (if possible).

What do you think?

#12 Updated by Gabriele Giammatteo over 2 years ago

A quick search for "comet" in the tabman Maven project reports the following:

pom.xml:            <artifactId>operation-comet</artifactId>
src/test/resources/cl_species.csv:PZE,,,,Perryena leucometopon,(Waite 1922)
src/test/resources/cl_species.csv:OBR,,,,Benthocometes robustus,(Goode & Bean 1886)
src/test/resources/cl_species.csv:EEP,Comet grouper,Mérou comète,Mero cometa,Epinephelus morrhua,(Valenciennes 1833)
src/test/resources/cl_species.csv:WPM,Pacific harvestfish,Stromaté du Pacifique,Palometa cometrapo,Peprilus medius,(Peters 1869)

It seems no ".java" file is referring to anything in operation-comet. At least at compile-time operation-comet dependency is not needed.

Also the Maven dependency-analyze plugin report it (and several others!) as unused:

[WARNING] Unused declared dependencies found:
[WARNING]    org.gcube.data.analysis.tabulardata:operation-view:jar:1.2.3-4.5.0-132347:compile
[WARNING]    org.gcube.data.analysis.tabulardata:operation-sdmx:jar:3.1.1-4.5.0-148356:compile
[WARNING]    org.gcube.data.analysis.tabulardata:operation-labels:jar:1.0.4-4.5.0-125894:compile
[WARNING]    org.gcube.data.analysis.tabulardata:operation-statistical:jar:1.2.4-4.5.0-147150:compile
[WARNING]    com.google.code.gson:gson:jar:2.2.4:compile
[WARNING]    org.gcube.data.analysis.tabulardata:operation-data:jar:1.3.3-4.5.0-125082:compile
[WARNING]    org.gcube.data.analysis.tabulardata:operation-comet:jar:1.0.3-4.5.0-125081:compile

Of course, this does not tell us anything about the run-time. Maybe these unused artifacts are included in the service package and discovered at runtime as plugins?

#13 Updated by Fabio Sinibaldi over 2 years ago

Indeed, operation modules are plugins. Moreover, their invocation is made by specifying their identifier (which is a String), so you won't be able to track their dependency in Java.
As Lucio stated, from the service point of view there shouldn't be any problem to remove the dependency from the pom.
AFAIK, the only invoker of this operation is the GUI (TDM portlet), which could simply hide / remove the button that makes the invocation. We just need to wait for @g.panichi@isti.cnr.it to give us feedback on this, but I think there wouldn't be any problem.

#14 Updated by Gabriele Giammatteo over 2 years ago

Fabio Sinibaldi wrote:

Indeed, operation modules are plugins. Moreover, their invocation is made by specifying their identifier (which is a String), so you won't be able to track their dependency in Java.
As Lucio stated, from the service point of view there shouldn't be any problem to remove the dependency from the pom.
AFAIK, the only invoker of this operation is the GUI (TDM portlet), which could simply hide / remove the button that makes the invocation. We just need to wait for @g.panichi@isti.cnr.it to give us feedback on this, but I think there wouldn't be any problem.

ok! thanks for the explanation

#15 Updated by Pasquale Pagano over 2 years ago

  • Assignee changed from Fabio Sinibaldi to Giancarlo Panichi

According to the last comment, it is needed your final comment to remove those dependencies.

#16 Updated by Maria Di Girolamo over 2 years ago

  • Priority changed from Normal to Immediate

Please, @g.panichi@isti.cnr.it is it possible to remove it?

#17 Updated by Giancarlo Panichi over 2 years ago

  • Assignee changed from Giancarlo Panichi to Lucio Lelii

This issue is not related to the portlet as I wrote 13 days ago, it is pointless to reassign this ticket to me.
The portlet does not use that operation, this issue concerns the service.
Please @lucio.lelii@isti.cnr.it fix this dependency

#18 Updated by Lucio Lelii over 2 years ago

I have removed the comet mapping dependency from the service. The release ticket is #8768

#19 Updated by Lucio Lelii over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

#20 Updated by Maria Di Girolamo over 2 years ago

  • Related to Release #8923: org.gcube.data-access.comet-mapping-format (to be removed) added

Also available in: Atom PDF